-
Notifications
You must be signed in to change notification settings - Fork 134
feat(core/ix-select): Add +1 chip #2371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
e0581e0
implementation
lzeiml ff5a8bd
fix
lzeiml 472db0f
Create stupid-sheep-grin.md
lzeiml a8914b4
Update .changeset/stupid-sheep-grin.md
lzeiml d39ccd7
fixes
lzeiml 71f1b5d
update visual tests + rebuild
lzeiml 774cb37
hide placeholder when selection active
lzeiml 5a6bc66
implement new overflow logic
lzeiml b849902
fix height
lzeiml f289134
update snapshots
lzeiml 5259139
Merge branch 'main' into feature/3720_select-overflow
lzeiml 9707e1c
lint fix
lzeiml 2a727c8
Merge branch 'feature/3720_select-overflow' of https://github.com/sieโฆ
lzeiml 3ba66cc
snapshots
lzeiml 1066619
Merge branch 'main' into feature/3720_select-overflow
lzeiml b8020f7
Merge branch 'main' into feature/3720_select-overflow
lzeiml d16f3a9
Merge branch 'main' into feature/3720_select-overflow
lzeiml 31f9aa5
merge
lzeiml 94eba39
update snapshots
lzeiml f98465d
final test fix
lzeiml 4096bb1
fix
lzeiml f17d50b
add fixed input width, fix chip widths logic
lzeiml 5ab9e46
Merge branch 'main' into feature/3720_select-overflow
lzeiml 1e79425
Merge branch 'main' into feature/3720_select-overflow
lzeiml 87dc567
Merge branch 'feature/3720_select-overflow' of https://github.com/sieโฆ
lzeiml bd223f0
Merge branch 'main' into feature/3720_select-overflow
lzeiml 6b97781
fix display styling, fix ix-warning styling
lzeiml 50820ed
fix tests
lzeiml 8c47e02
fix tests
lzeiml 00785ff
fixes
lzeiml f40d8f3
fixes
lzeiml 7e354be
fix/adjust test
lzeiml 30013ad
sonar fix
lzeiml 9725a04
fix
lzeiml d3cbe77
fix
lzeiml bdeee29
adjust preview examples
lzeiml 276ec4d
fix
lzeiml eb0979e
add tests
lzeiml 7a05fcc
Merge branch 'main' into feature/3720_select-overflow
lzeiml 1f432e9
sonar fix
lzeiml cfb5c54
sonar fix
lzeiml 5ebfc65
fix
lzeiml cb1f6cf
fix
lzeiml f2eccde
fix
lzeiml 36c9f3e
Merge branch 'main' into feature/3720_select-overflow
lzeiml File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@siemens/ix": minor | ||
| --- | ||
|
|
||
| In multiple-mode **ix-select** now displays "+<number>" for the number of items that are selected if more than two items have been selected. | ||
Binary file modified
BIN
+195 Bytes
(100%)
...tton-in-cell-should-appear-above-other-rows-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-49 Bytes
(100%)
...ton-in-cell-should-appear-above-other-rows-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+122 Bytes
(100%)
...lect-in-cell-should-appear-above-other-rows-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-51 Bytes
(100%)
...ect-in-cell-should-appear-above-other-rows-1-chromium---classic-light-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-383 Bytes
(97%)
.../aggrid-header-checkbox-should-be-unchecked-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-20 Bytes
(100%)
...s/aggrid.e2e.ts-snapshots/aggrid-pagination-1-chromium---classic-dark-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changeset text says the "+" indicator is shown "if more than two items have been selected", but the implementation shows the overflow chip based on available width (chips exceeding container width), which may not always correspond to "more than two". Please adjust the changeset wording to match the actual behavior (overflow-based summarization) to avoid misleading release notes.