Skip to content

refactor(application-header): remove deprecated component.#2307

Merged
spike-rabbit merged 1 commit into
mainfrom
refactor/remove-deprecated-si-header-logo-component
Jul 10, 2026
Merged

refactor(application-header): remove deprecated component.#2307
spike-rabbit merged 1 commit into
mainfrom
refactor/remove-deprecated-si-header-logo-component

Conversation

@akashsonune

@akashsonune akashsonune commented Jul 9, 2026

Copy link
Copy Markdown
Member

BREAKING CHANGE: Removed deprecated component SiHeaderSiemensLogoComponent, instead use SiHeaderLogoDirective


Documentation.
Examples.
Dashboards Demo.
Playwright report.

Coverage Reports:

Code Coverage

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated SiHeaderSiemensLogoComponent component from the application header package, including its source file, public exports, documentation, and API golden files. I have no feedback to provide on these changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@akashsonune akashsonune force-pushed the refactor/remove-deprecated-si-header-logo-component branch 2 times, most recently from d8ea776 to abaa076 Compare July 9, 2026 18:44
@akashsonune akashsonune added the breaking-changes Marks issues and PRs that are breaking the API label Jul 9, 2026
@akashsonune akashsonune added this to the 51.0.0 milestone Jul 9, 2026
@akashsonune akashsonune marked this pull request as ready for review July 9, 2026 19:02
@akashsonune akashsonune requested review from a team as code owners July 9, 2026 19:02
@akashsonune akashsonune requested a review from spike-rabbit July 9, 2026 19:02
@akashsonune akashsonune force-pushed the refactor/remove-deprecated-si-header-logo-component branch from abaa076 to caca565 Compare July 10, 2026 08:15
BREAKING CHANGE: Removed component `SiHeaderSiemensLogoComponent`. Use `SiHeaderLogoDirective` instead.

```html
<!-- Before -->
<a si-header-siemens-logo routerLink="/" aria-label="Siemens" class="d-none d-md-flex"></a>

<!-- After -->
<a siHeaderLogo routerLink="/" class="d-none d-md-flex"></a>
```
@akashsonune akashsonune changed the title refactor(application-header): Removed deprecated component. refactor(application-header): remove deprecated component. Jul 10, 2026
@akashsonune akashsonune force-pushed the refactor/remove-deprecated-si-header-logo-component branch from caca565 to 45c6a8c Compare July 10, 2026 09:13

@spike-rabbit spike-rabbit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit cdfca87 Jul 10, 2026
15 checks passed
@spike-rabbit spike-rabbit deleted the refactor/remove-deprecated-si-header-logo-component branch July 10, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes Marks issues and PRs that are breaking the API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants