refactor(live-preview): migrate live-preview to signals#2278
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the SiLivePreviewComponent to adopt Angular's signal-based inputs (input and model) instead of the traditional @input decorators, updating both the component class and its HTML template. The review feedback recommends migrating the remaining ticketBaseUrl input to the signal-based input() function to fully comply with the repository style guide. Additionally, the reviewer suggests caching signal reads (such as this.example() and this.baseUrl()) in local variables across multiple methods to avoid redundant evaluations and improve code readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
PR title is confusing. This is a signal migration (which is fine), not making in OnPush. We cannot mark live-preview as OnPush as it will break any examples that rely on Default. Everything is marked as Default and it should stay that way, at least for a few releases. Having signals is the right thing to do as stuff will work in either case. |
e9fb7b7 to
1fe43e7
Compare
BREAKING CHANGE: The live-preview components were migrated to signal inputs.
1fe43e7 to
0b709ac
Compare
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: