Skip to content

fix(breadcrumb): add space key activation to dropdown toggle #2061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akashsonune wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −10
Open

fix(breadcrumb): add space key activation to dropdown toggle #2061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions projects/element-ng/breadcrumb/si-breadcrumb.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,16 +80,14 @@
</ng-template>

<ng-template #toggleTemplate let-item="item" let-title="title" siBreadcrumbItemTemplate>
<div
class="breadcrumb-dropdown-toggle link"
role="button"
<button
type="button"
class="btn btn-link"
aria-haspopup="true"
tabindex="0"
[attr.aria-controls]="controlId + item.level"
[attr.aria-expanded]="breadcrumbDropdownOpen === item.level"
(keydown.enter)="toggleBreadcrumbDropdown(item.level)"
(click)="toggleBreadcrumbDropdown(item.level)"
>{{ title }}...</div
>{{ title }}...</button
>
</ng-template>

Expand Down
4 changes: 0 additions & 4 deletions projects/element-ng/breadcrumb/si-breadcrumb.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
margin-inline: 0;
}

.breadcrumb-dropdown-toggle {
cursor: pointer;
}

// overwrite some of Bootstrap's dropdown styling
.dropdown-item {
&.active,
Expand Down
Loading