Skip to content

feat(charts): Improve accessibility with keyboard interaction #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akashsonune wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(charts): Improve accessibility with keyboard interaction #1964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api-goldens/charts-ng/common/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,7 @@ export interface SeriesUpdate<SeriesType> {
// @public (undocumented)
export class SiChartBaseComponent implements AfterViewInit, OnChanges, OnInit, OnDestroy {
readonly additionalOptions: _angular_core.InputSignal<EChartOption | undefined>;
readonly ariaLabel: _angular_core.InputSignal<string | undefined>;
readonly autoZoomSeriesIndex: _angular_core.InputSignal<number>;
readonly axisPointer: _angular_core.InputSignal<string | boolean | undefined>;
readonly chartContainerWrapper: _angular_core.Signal<ElementRef<any>>;
Expand Down
1 change: 1 addition & 0 deletions api-goldens/charts-ng/index.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,7 @@ export { SiCandlestickSeriesOption as SimplCandlestickSeriesOption }
// @public (undocumented)
export class SiChartBaseComponent implements AfterViewInit, OnChanges, OnInit, OnDestroy {
readonly additionalOptions: i0.InputSignal<EChartOption | undefined>;
readonly ariaLabel: i0.InputSignal<string | undefined>;
readonly autoZoomSeriesIndex: i0.InputSignal<number>;
readonly axisPointer: i0.InputSignal<string | boolean | undefined>;
readonly chartContainerWrapper: i0.Signal<ElementRef<any>>;
Expand Down
2 changes: 1 addition & 1 deletion playwright/snapshots/dashboard.spec.ts-snapshots/dashboard--mobile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,4 @@
- text: Fri
- img "Fri"
- 'img /Wind: [\d,.]+[bkmBKM]+\/h/'
- text: /\d+° \d+°/
- text: /\d+° \d+°/
2 changes: 1 addition & 1 deletion playwright/snapshots/dashboard.spec.ts-snapshots/dashboard--normal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@
- text: Fri
- img "Fri"
- 'img /Wind: [\d,.]+[bkmBKM]+\/h/'
- text: /\d+° \d+°/
- text: /\d+° \d+°/
2 changes: 1 addition & 1 deletion playwright/snapshots/dashboard.spec.ts-snapshots/dashboard--tablet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,4 @@
- listitem:
- text: Fri
- img "Fri"
- text: /\d+° \d+°/
- text: /\d+° \d+°/
2 changes: 1 addition & 1 deletion playwright/snapshots/dashboard.spec.ts-snapshots/dashboard--weather-preplaced.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,4 +124,4 @@
- text: Fri
- img "Fri"
- 'img /Wind: [\d,.]+[bkmBKM]+\/h/'
- text: /\d+° \d+°/
- text: /\d+° \d+°/
2 changes: 1 addition & 1 deletion playwright/snapshots/dashboard.spec.ts-snapshots/dashboard--weather-tablet.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,4 @@
- listitem:
- text: Fri
- img "Fri"
- text: /\d+° \d+°/
- text: /\d+° \d+°/
8 changes: 6 additions & 2 deletions ...t/snapshots/si-dashboard.spec.ts-snapshots/si-dashboard--si-dashboard-layout--mobile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
- button "Launchpad"
- heading "Smart Buildings" [level=1]
- button "API"
- button "Jane Smith"
- button "Jane Smith": JS
- navigation:
- button "expand"
- main:
Expand All @@ -27,6 +27,7 @@
- text: Today's motivation level (without global filter)
- menubar:
- menuitem "Expand"
- application
- text: Lorem ipsum
- paragraph: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc at augue ornare, suscipit orci a, dapibus enim. Duis nibh diam, consequat vitae dolor eu, consectetur hendrerit nulla. Nam consectetur consequat suscipit. Nam consectetur pulvinar risus, nec auctor lorem. Sed eget magna quis turpis finibus rhoncus.
- text: Door access events this week
Expand All @@ -36,7 +37,10 @@
- text: Reasons to remember the name
- menubar:
- menuitem "Expand"
- text: Daily requirements at work Contributions
- application
- text: Daily requirements at work
- application
- text: Contributions
- button "Toggle"
- text: /\d+ bits Valuable bits commited to main\./
- link "Do something":
Expand Down
8 changes: 6 additions & 2 deletions playwright/snapshots/si-dashboard.spec.ts-snapshots/si-dashboard--si-dashboard-layout.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
- /url: "#/"
- heading "Smart Buildings" [level=1]
- button "API"
- button "Jane Smith"
- button "Jane Smith": JS
- navigation:
- button "collapse" [expanded]
- button "Home"
Expand Down Expand Up @@ -38,6 +38,7 @@
- text: Today's motivation level (without global filter)
- menubar:
- menuitem "Expand"
- application
- text: Lorem ipsum
- paragraph: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc at augue ornare, suscipit orci a, dapibus enim. Duis nibh diam, consequat vitae dolor eu, consectetur hendrerit nulla. Nam consectetur consequat suscipit. Nam consectetur pulvinar risus, nec auctor lorem. Sed eget magna quis turpis finibus rhoncus.
- text: Door access events this week
Expand All @@ -47,7 +48,10 @@
- text: Reasons to remember the name
- menubar:
- menuitem "Expand"
- text: Daily requirements at work Contributions
- application
- text: Daily requirements at work
- application
- text: Contributions
- button "Toggle"
- text: /\d+ bits Valuable bits commited to main\./
- link "Do something":
Expand Down
11 changes: 10 additions & 1 deletion projects/charts-ng/common/si-chart-base.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,16 @@
/>
}
}
<div #chart class="echart-container" [style.height.px]="containerHeight()"></div>
<div
#chart
class="echart-container"
[style.height.px]="containerHeight()"
[attr.tabindex]="showCustomLegend() ? 0 : null"
[attr.role]="showCustomLegend() ? 'application' : null"
[attr.aria-label]="showCustomLegend() ? ariaLabel() : null"
(focus)="onChartFocus()"
(blur)="onChartBlur()"
></div>
</div>
</div>
@if (externalZoomSlider()) {
Expand Down
Loading
Loading