Add pre-commit hooks for shellcheck and secret scanning - #4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add pre-commit hooks for shellcheck and secret scanning#4devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Wire up shellcheck to catch shell scripting defects in install.sh and uninstall.sh, and gitleaks to prevent hardcoded secrets from entering the repository. Both run clean against the current tree. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A security scan of this repo found no vulnerabilities — the requested classes (SQLi, CORS, auth, insecure deps, debug endpoints) don't apply since there's no application code, only markdown skills, two shell scripts, and JSON config. No secrets are present.
This PR adds preventative hardening rather than fixing a defect: a
.pre-commit-config.yamlwiring two hooks.shellcheck(koalaman/shellcheck-precommit v0.10.0) — lintsinstall.sh/uninstall.sh; both currently pass clean.gitleaks(v8.21.2) — blocks hardcoded secrets from ever being committed.Both hooks pass against the current tree (
pre-commit run --all-files). To activate locally, contributors runpre-commit install(pre-commit itself is the only new tooling dependency).Link to Devin session: https://app.devin.ai/sessions/0b0ed156ce5a4b82b8a247130bf97068
Requested by: @sidwood