Harden symlink cleanup error handling

[devin-ai-integration]

Summary

The only executable code in this repo is install.sh and uninstall.sh; the rest is markdown skills. Two error-handling weaknesses in those scripts are fixed.

1. Legacy cleanup aborted the whole run on an unresolvable symlink. remove_link_if_target resolves a relative link target by cd-ing into the target's parent dir. If that dir is missing (e.g. an unrelated broken symlink in ~/.claude/skills), the cd fails under set -euo pipefail and the entire install/uninstall aborts with a cryptic cd: No such file or directory, skipping all remaining cleanup. Now the resolution is guarded and an unresolvable link is skipped with a clear warning:

if ! resolved_dir="$(cd "$(dirname "$link_path")" && cd "$(dirname "$link_target")" 2>/dev/null && pwd -P)"; then
  echo "Warning: could not resolve symlink target for '$link_path'; skipping." >&2
  return 0
fi

2. rmdir swallowed every error. rmdir "$DIR" 2>/dev/null || true (uninstall) discarded all failures, including real ones (permissions), not just the expected non-empty case. Replaced with an explicit empty check so genuine failures still propagate via set -e:

for skills_dir in "$CLAUDE_SKILLS_DIR" "$CODEX_SKILLS_DIR"; do
  if [ -d "$skills_dir" ] && [ -z "$(ls -A "$skills_dir")" ]; then
    rmdir "$skills_dir"
  fi
done

Applied the resolution guard to both scripts (the helper is duplicated).

Testing

• Reproduced the pre-fix abort: a broken relative symlink made the old resolver exit 1 mid-run.
• Post-fix, install + uninstall complete (exit 0) with an unrelated broken symlink present, leave it untouched, and correctly remove the skills dir only when empty. Idempotent re-install verified. bash -n clean on both scripts.

Link to Devin session: https://app.devin.ai/sessions/c58c81d23fc54b15bd512e7da87bdb36
Requested by: @sidwood

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring