fix #805 edit jpg can not refresh#806
Merged
Photon89 merged 2 commits intoshutter-project:masterfrom May 9, 2026
Merged
Conversation
Member
|
Thanks for the PR! I tested it and can confirm that it fixes the issue. |
|
|
||
| my $v = $session_screens{$key}; | ||
| if ($v && -e $v->{'giofile'}->get_path) { | ||
| print "deleted - $key exists ignored\n" if $sc->get_debug; |
Member
There was a problem hiding this comment.
I don't understand what this sentence means
Member
There was a problem hiding this comment.
Me neither, it does some magic! 😃
Contributor
Author
There was a problem hiding this comment.
because save do $exiftool->WriteInfo($filename); in os is mv
- create a tmp file
mv tmp $filename
os will notify event:deleted, in fact the $filename is not deleted, it still exist in os, just innode changed.
Member
There was a problem hiding this comment.
After asking the AI, I think this makes sense. The return line seems to prevent that the file is considered as deleted and thus not updated any more.
Photon89
approved these changes
Mar 21, 2026
vadi2
approved these changes
May 3, 2026
DarthGandalf
reviewed
May 9, 2026
Member
|
I probably shouldn't have commented in a resolved conversation. Is this PR good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.