Fix: select returns empty array when cleared#671
Open
Alastair Fraser (alastair-simon) wants to merge 1 commit intomainfrom
Open
Fix: select returns empty array when cleared#671Alastair Fraser (alastair-simon) wants to merge 1 commit intomainfrom
Alastair Fraser (alastair-simon) wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/component-library/src/components/form/mt-select/mt-select.vue
Outdated
Show resolved
Hide resolved
Alastair Fraser (alastair-simon)
requested review from
Nils Haberkamp (Haberkamp) and
Bojan Rajh (bojanrajh)
Dennis Mader (Weltraumakustik)
added
package: components
test: add test to verify clear null value fix: add changeset fix: visual test to reflect null value fix: allow empty array return if multiSelect enabled fix: visual clear test test: add additional unit test refactor: simplify logic
Alastair Fraser (alastair-simon)
force-pushed
the
fix/select-clear-return
branch
from
c5eaffb to
b0d1f05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #293
Why?
The select component returns an empty array when cleared instead of null
How?
I have set the return value to be null now
Testing?
I added a unit test to verify this change works as expected