fix: exception messages#150
Open
Jozsef Damokos (jozsefdamokos) wants to merge 17 commits intotrunkfrom
Open
Conversation
Member
Jozsef Damokos (jozsefdamokos)
commented
Mar 5, 2026
Jozsef Damokos (jozsefdamokos)
commented
- include exception file and line in log entry exception message
- fix exception in ConverterRegistry
- make OrderWriter magento proof
- remove magento 1.9 profile+ add magento 2.4 profile
Jozsef Damokos (jozsefdamokos)
changed the title
Jozsef Damokos (jozsefdamokos)
requested review from
a team,
Simon Fiebranz (CR0YD),
Dennis Garding (DennisGarding),
Malte Janz (MalteJanz),
Susanne Hartung (ennasus4sun),
Lars Kemper (larskemper) and
Nikolas Evers (vintagesucks)
and removed request for
a team
Malte Janz (MalteJanz)
approved these changes
Mar 6, 2026
src/Profile/Shopware/Converter/MainVariantRelationConverter.php
Outdated
Show resolved
Hide resolved
tests/acceptance/snapshots/MigrationTest.spec.ts/linux/migration-log-sw5.txt
Outdated
Show resolved
Hide resolved
Malte Janz (MalteJanz)
approved these changes
Mar 6, 2026
Lars Kemper (larskemper)
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.