Open
Conversation
Introduces a headless rendering mode that allows rendering a single frame and saving it as a PNG image using a new ImageSaver utility. Adds an --output flag to the viewer app for specifying the output image path, updates configuration and window creation to support invisible windows for headless mode, and integrates stb_image_write for PNG export. Also updates CMake to fetch stb and include its headers.
Defines VK_DRIVER_ID_MESA_AGXV and VK_BUFFER_USAGE_2_EXECUTION_GRAPH_SCRATCH_BIT_AMDX if they are not already defined. This ensures compatibility with code referencing these enums even if the Vulkan headers are outdated.
Introduces CameraConfig for loading and saving camera parameters from file. Adds command-line option to specify a camera config file, updates Renderer to load camera settings from file if provided, and documents example camera config formats. This enables reproducible and scriptable camera setups for rendering.
sometimes buffer allocation failed in subsequent calls when it fails fail gracefully
return value was discarded but this was not allowed
handleInput is not needed in headless mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows rendering to file when specified in cli argument like --output rendered_image.png --width 1920 --height 1080
#49