[Closed] Allow custom LibreOffice binary path via environment variable#323
Closed
daido1976 wants to merge 1 commit intoshelfio:masterfrom
Closed
[Closed] Allow custom LibreOffice binary path via environment variable#323daido1976 wants to merge 1 commit intoshelfio:masterfrom
daido1976 wants to merge 1 commit intoshelfio:masterfrom
Conversation
Author
|
Close PR because I want to change the head branch. |
daido1976
changed the title
daido1976
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to update the LibreOffice version in shelfio/libreoffice-lambda-base-image. However, since the LibreOffice binary version and path are hardcoded in the following location, if there is an application already in operation, changes need to be applied simultaneously to both repositories, making it challenging to upgrade the version.
aws-lambda-libreoffice/src/convert.ts
Line 17 in 6e23c3c
With this PR, the
LO_BINARY_PATHenvironment variable allows injecting the version and path of LibreOffice, simplifying the upgrade process.