Fix evaluation of SOURCE_ROOT path - #1
Merged
Merged
Conversation
lowdesertpunk
left a comment
lowdesertpunk
left a comment
There was a problem hiding this comment.
Please add a unit test similarly as done in https://github.com/CocoaPods/Xcodeproj/pull/739/files
And then lets open PR for upstream too.
The value `SOURCE_ROOT` resolves to in Xcode and in CocoaPods differs, causing `pod install` to emit warnings about the `xcconfig` files not being used properly for targets generated from CMake.
miki-shapr
force-pushed
the
source-root-fix
branch
from
August 15, 2025 07:51
6e8babc to
365d6a6
Compare
Author
|
The tests can be executed using this command: bundle exec rake spec:all |
lowdesertpunk
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of the
SOURCE_ROOTvariable was evaluated incorrectly by CocoaPods.In Xcode, it is the path to the root of the repository (e.g.
~/Developer/shapr3d) but in the CocoaPods implementation, it was expanded to the path to the project, which, in the case ofKernelProject.xcodeprojwas~/Developer/shapr3d/build/cmake.This mismatch caused CocoaPods to not find the
.xcconfigfile of targets generated by CMake (e.g.SPLibBinginsTests).Tip
See CocoaPods/CocoaPods#6268 for more info. Specifically this comment.
Note
Opened a PR for upstream: CocoaPods#1024