fix: use buffered gas estimate and wait for swap tx confirmation#221
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThe swap execution flow now includes EVM-only post-transaction confirmation waiting, ensuring swap transactions are confirmed before advancing. Additionally, gas handling logic was updated to select the larger value between explicitly provided gas and simulated estimated gas. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
Swap transactions (particularly USDC → ETH on Arbitrum) reverted on-chain because the provider gas limit was used as-is, ignoring the simulation's 20% buffered estimate. Now uses the greater of the two values. Additionally, swap steps now wait for on-chain confirmation before showing a success toast, so reverted transactions correctly surface as errors. Fixes: tic-94af, tic-32f9 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
a09a032 to
5636c39
Compare
Summary
Fixes: tic-94af, tic-32f9
Test plan
bun run type-check && bun testpass🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Chores