fix: Safe deployment gas estimation on Arbitrum#219
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
premiumjibles
force-pushed
the
fix/safe-deployment-gas-estimation
branch
from
ee60245 to
e9dbbc2
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughChanges introduce stablecoin detection to conditionally render price-change indicators, enhance Safe transaction execution with a composite provider pattern for read/write routing, remove loading state from asset metrics, implement persistent storage with IDB-to-localStorage fallback recovery, and add browser storage persistence requests during app bootstrap. Changes
Sequence DiagramssequenceDiagram
participant App
participant CompositeProvider as Composite Provider
participant PublicClient as Public Client (RPC)
participant WalletProvider as Wallet Provider
participant SafeKit as Safe.init()
App->>CompositeProvider: createSafeProvider(chainId, provider)
CompositeProvider->>SafeKit: Pass composite provider
Note over App,SafeKit: Execution phase
App->>CompositeProvider: request(read-only method)
CompositeProvider->>PublicClient: Forward eth_call, eth_getCode, etc.
PublicClient-->>CompositeProvider: Response
CompositeProvider-->>App: Return result
App->>CompositeProvider: request(other method)
CompositeProvider->>WalletProvider: Forward transaction/write
WalletProvider-->>CompositeProvider: Response
CompositeProvider-->>App: Return result
sequenceDiagram
participant Store as Chat Store
participant IDB as IndexedDB
participant LocalStorage as localStorage
participant Hydration as Rehydrate Callback
Store->>IDB: Read conversations on init
alt IDB Read Success
IDB-->>Store: Conversations loaded
alt Conversations empty
Store->>LocalStorage: Read backup
LocalStorage-->>Store: Fallback data
Store->>Store: Validate & assign backup
else Conversations present
Store->>Store: Use IDB data
end
else IDB Read Fails
IDB-->>Store: Error logged
Store->>LocalStorage: Attempt localStorage recovery
LocalStorage-->>Store: Backup data
Store->>Store: Validate & assign backup
end
Store->>Hydration: Mark hydrationVerified = true
Hydration->>IDB: Enable subsequent writes
Estimated Code Review Effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Safe deployments on Arbitrum revert with out-of-gas because the SDK's createSafeDeploymentTransaction() returns no gas fields and wallet estimation underestimates. Add estimateGas() + 20% buffer before sendTransaction, matching the existing pattern in simulation.ts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
WalletConnect wallets (e.g. ShapeShift native) don't properly relay read-only RPC calls like eth_call and eth_getCode, causing Safe SDK init to fail with "Missing or invalid parameters. Failed to fetch Version". Creates a composite provider that routes reads through a public RPC (with viem fallback transport for resilience) while keeping write/sign operations on the wallet provider. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
premiumjibles
force-pushed
the
fix/safe-deployment-gas-estimation
branch
from
6049965 to
05df5cf
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…licate RPC transports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
estimateGas()+ 20% buffer before sending Safe deployment transactionssimulation.tsfor EOA transactionsTest plan
bun run type-checkandbun testpass🤖 Generated with Claude Code
Summary by CodeRabbit
Bug Fixes
Improvements