Fix unnecessary gist rewrites during sync upload#1465
Open
cedar323 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keybindings*variantsWhy
Issue #508 reports that every sync upload rewrites all gist files, which produces unnecessary updates. This change computes a minimal gist patch from the remote gist state and local setting files, then sends only changed entries plus explicit deletions.
Compared with #1461, this also verifies the actual PATCH payload shape and preserves remote keybindings variants from accidental deletion.
Validation
npx tsc src/service/gistUpdate.ts test/service/gistUpdate.test.ts --module commonjs --target es2018 --lib es2018 --types node,mocha,chai --esModuleInterop --skipLibCheck --outDir .tmp-gistupdate-testnode .\\node_modules\\mocha\\bin\\mocha .\\.tmp-gistupdate-test\\test\\service\\gistUpdate.test.js