Upload only changed settings files#1464
Open
sgibler-droid wants to merge 1 commit into
Open
Conversation
2031e8d to
e35ef12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #508.
Summary
This changes the upload flow so normal uploads send only files that are new or changed, plus the
cloudSettingsmetadata file. Forced uploads keep the previous all-files behavior.The important safety detail is in
UpdateGIST: it now separates the files being added/updated from the complete local file set used for deletion decisions. Without that separation, passing only changed files could accidentally mark unchanged remote gist files for deletion.Changes
GistChangeServiceto detect changed/new setting files and derive the upload payload.sync.forceUploadis enabled.Verification
Ran locally:
Results:
I also verified the existing full test suite locally with a VS Code runtime shim, since this older test harness imports
vscodeunder Mocha.