Skip to content

Close open settings files before download overwrite#1459

Open
apples-kksk wants to merge 1 commit into
shanalikhan:masterfrom
apples-kksk:fix-download-open-file-conflicts
Open

Close open settings files before download overwrite#1459
apples-kksk wants to merge 1 commit into
shanalikhan:masterfrom
apples-kksk:fix-download-open-file-conflicts

Conversation

@apples-kksk

@apples-kksk apples-kksk commented May 9, 2026

Copy link
Copy Markdown

Fixes #396.

Summary

  • Close visible editors for files that are about to be overwritten during download sync.
  • Normalize file paths before matching open editors, including case-insensitive matching on Windows.
  • Add a VS Code extension-host test for closing an open settings file.

Verification

  • npm run tslint-check
  • ./node_modules/.bin/tsc -p ./
  • npm run compile
  • npm run vscode:prepublish
  • CODE_TESTS_DATA_DIR="$(mktemp -d)" xvfb-run -a node ./node_modules/vscode/bin/test

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload/Download Conflicts

1 participant