WIP: kdn decode pto-isa - #635
Open
fiskrt wants to merge 5 commits into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fiskrt
marked this pull request as ready for review
July 29, 2026 14:09
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A vector-only PTO-ISA kernel for the kimi-delta-attention (KDA) decoding (extend in sglang lingo) stage. Will mostly be called from sglang in packed format (i.e B=1, T=number of sequences and cu_seqlens are just 1's), initial state is always provided along with a list of the state indices. For kimi-linear
l2norm=True.TODO:
Bench
Kernel vs kernel
Benchmark against the Triton kernel. N/a means that Triton fails due to too many blocks launched (max is 64k)
End to end
Depending on the context length the kdn doce kernel is can between 5-20% of a linear layer, and around 1-8% of whole transformer.
At 128 concurrent decoding sessions , pto-isa sees avg 125 us, while triton sees 160 us. With short sequence length at this setting this gives us an end2end speedup of 5%. Measuring with
sglang.bench_one_batchto avoid the scheduler overhead.PTO:

Triton

Notes:
cu_seqlens[i+1]-cu_seqlens[i]>1aswell but the double buffering and testing could be more looked in to.