doc: add doc best-practice/deploy-mooncake-store-with-rbg#391
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/copilot review |
|
@gemini-code-assist /review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Review: doc: add doc best-practice/deploy-mooncake-store-with-rbgOverall this is a well-structured documentation set covering Mooncake Store deployment with RBG. However, the Blocking Issues
Non-blocking Issues
Please fix the CI failures and the broken link, then this should be good to go. |
|
|
||
| ```bash | ||
| # Check all Pod statuses | ||
| kubectl get pods -l rbg.workloads.x-k8s.io/group-name=mooncake-service -o wide |
There was a problem hiding this comment.
This text says "Total L3 cache capacity = 3 replicas x 10 GB = 30 GB", but the YAML above specifies replicas: 1 and MOONCAKE_GLOBAL_SEGMENT_SIZE: "100gb". The verification output below also confirms a 100 GB pool. Please reconcile this -- either update the YAML to 3 replicas/10gb, or update this text to match the actual 1-replica/100gb configuration.
| @@ -0,0 +1,431 @@ | |||
| # Operations Guide: Deploying Mooncake Store with RBG for KV Cache Reuse | |||
|
|
|||
| > Corresponding concept document: [10. Deploying Mooncake Store with RBG for KV Cache Reuse](../10.%20通过%20RBG%20部署%20Mooncake%20Store%20实现%20KV%20Cache%20复用.md) | |||
There was a problem hiding this comment.
This cross-reference links to ../10. 通过 RBG 部署 Mooncake Store 实现 KV Cache 复用.md which does not correspond to any file in the repository. The concept document appears to be at ./10-deploy-mooncake-store-with-rbg.md (same directory). Please update this link. Same issue in the ZH guide.
|
/copilot review |
|
@gemini-code-assist /review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
| @@ -0,0 +1,431 @@ | |||
| # Operations Guide: Deploying Mooncake Store with RBG for KV Cache Reuse | |||
|
|
|||
| > Corresponding concept document: [10. Deploying Mooncake Store with RBG for KV Cache Reuse](../10.%20通过%20RBG%20部署%20Mooncake%20Store%20实现%20KV%20Cache%20复用.md) | |||
There was a problem hiding this comment.
The cross-reference ../10.%20通过%20RBG%20部署%20Mooncake%20Store%20实现%20KV%20Cache%20复用.md does not match the actual concept doc filename 10-deploy-mooncake-store-with-rbg.md. Since both files are in the same en/ directory, this should be ./10-deploy-mooncake-store-with-rbg.md.
| - sh | ||
| - -c | ||
| - "ulimit -l unlimited && python -m mooncake.mooncake_store_service --port 52859" | ||
| ports: |
There was a problem hiding this comment.
Item 4 states "Total L3 cache capacity = 3 replicas x 10 GB = 30 GB" but the YAML above deploys replicas: 1 with MOONCAKE_GLOBAL_SEGMENT_SIZE: "100gb". The actual verification output correctly shows 100.00 GB. Consider updating this line to match the actual deployment config.
| spec: | ||
| containers: | ||
| - name: engine | ||
| image: lmsysorg/sglang:v0.5.5 |
There was a problem hiding this comment.
The inference service snippet uses lmsysorg/sglang:v0.5.5 while the Mooncake Store YAML and the prerequisites note both reference v0.5.9. Consider aligning to a single version for clarity.
|
Reading this from a user's perspective, several things will trip people up: Two things that will likely break
The Summary table promises operations that don't exist: The Summary section lists "Benchmark" and "Lossless Update" as operations, but there are no corresponding step-by-step sections in the doc. Users will scroll looking for these and be confused. Either add the operations or remove them from the summary. Data doesn't match the config: In the concept doc's "Expected Behavior": "Total L3 cache capacity = 3 replicas × 10 GB = 30 GB". But the actual YAML has Hardware assumption: All examples assume RDMA ( Minor:
|
No description provided.