doc: add doc best-practice/using-role-templates#387
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/copilot review |
|
@gemini-code-assist /review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Well-structured documentation covering |
| # Verify Prefill Pod memory request is 16Gi (overridden by patch) | ||
| kubectl get pods -l rbg.workloads.x-k8s.io/role-name=prefill -o jsonpath='{.items[0].spec.containers[0].resources.requests.memory}' | ||
|
|
||
| > 8Gi |
There was a problem hiding this comment.
This expected output contradicts the surrounding text. The comment on line 360 says "Verify Prefill Pod memory request is 16Gi (overridden by patch)" and the summary on line 382 says "Prefill memory: 16Gi", but this line shows > 8Gi. Should be > 16Gi.
| # 验证 Prefill Pod 内存请求为 16Gi（被 patch 覆盖） | ||
| kubectl get pods -l rbg.workloads.x-k8s.io/role-name=prefill -o jsonpath='{.items[0].spec.containers[0].resources.requests.memory}' | ||
|
|
||
| > 8Gi |
There was a problem hiding this comment.
Same issue here: the comment says memory should be 16Gi (overridden by patch), but the expected output shows > 8Gi. Should be > 16Gi.
| kubectl get rbg <rbg-name> -o yaml | grep templateRef | ||
| ``` | ||
|
|
||
| ## Related Documents |
There was a problem hiding this comment.
Nit: the 'Related Documents' section links to 01-deploy-inference-service.md, 08-configuring-autoscaling.md, and 03-configuring-rolling-updates.md which don't exist on the target branch yet. Also 'Gang Scheduling Configuration' has no link. Fine to leave as placeholders if follow-up PRs will add these.
2 participants
No description provided.