doc: add doc best-practice/deploy-inference-service#386
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/copilot review |
|
@gemini-code-assist /review |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks for putting together this best-practice guide -- the multi-role and topology concepts are clearly explained with practical examples, and the operations guide is well-structured with verification steps. A few things to address before merge:
Items 1 and 2 are straightforward fixes. Once addressed, this should be good to go. |
| --- | ||
|
|
||
| ## Multi-Role Definition | ||
| The core concept of RBG is the **Role**. An inference service can consist of one or more roles, each承担ing different responsibilities. Depending on the inference architecture, the number and division of roles varies. |
There was a problem hiding this comment.
The sentence "each承担ing different responsibilities" contains Chinese characters in what should be pure English text. This looks like a leftover from translation. Suggest: "each taking on different responsibilities".
| kubectl get rbg <rbg-name> -o wide | ||
|
|
||
| # Check Pod status | ||
| kubectl get pods -l app=llm-inference |
There was a problem hiding this comment.
This command uses app=llm-inference which is never defined in any YAML example in this document. The correct label (as used in the operations guide) is rbg.workloads.x-k8s.io/group-name=<rbg-name>. Users following this will get empty results.
Suggested fix:
kubectl get pods -l rbg.workloads.x-k8s.io/group-name=<rbg-name>
| kubectl get rbg <rbg-name> -o wide | ||
|
|
||
| # 查看 Pod 状态 | ||
| kubectl get pods -l app=llm-inference |
There was a problem hiding this comment.
Same issue as the English version: app=llm-inference is never defined in any YAML example. Should use rbg.workloads.x-k8s.io/group-name=<rbg-name> to be consistent with the operations guide.
2 participants
No description provided.