Search extension from the end of the map name instead of from the start.#142
Merged
sezero merged 1 commit intosezero:masterfrom Jan 15, 2026
Merged
Search extension from the end of the map name instead of from the start.#142sezero merged 1 commit intosezero:masterfrom
sezero merged 1 commit intosezero:masterfrom
Conversation
Owner
|
Thanks, this.is in. Pu1shed a minor follow-up tıo it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the map command scans the name for a
.bspextension usingstrstr(). This works fine for any map that follows the naming stylename.bsp, but would break withpre.bspname.bspbecause it searches for the first occurence of.bspfrom the start.In the patch, I first search for the
.character usingQ_strrchr()which searches in reverse from the end of the string. If found, it compares usingQ_strcmp()and terminates the string there if the extension was found.I tested this by invoking the following commands:
My
id1/mapsdirectory in fact has the files for testing purposes:death.bsp → Death's Taste