Fix crash on launch reading out of bounds when loading some WAV files

[thomashope]

Crash appears to be caused by reading out of bounds memory when checking for the presence of "mark" inside the LIST chunk of certain WAV files. Possibly caused by badly authored WAV files, though I'm not sure exactly what the expected format & behaviour is here.

Crash occurred when trying to run librequake v0.09-beta FULL version on an M2 Mac, but it does not look like a Mac specific issue imo.

[sezero]

This is in. Thanks.

[sezero]

@vsonnier, @andrei-drexler: vkquake and ironwail might need this, too.

[andrei-drexler]

Thanks for the heads up!

[vsonnier]

@sezero Thanks, cherry-picked on vk as well.

[vsonnier]

@sezero @thomashope Are we sure of that patch ? I now see that warning quite often in mods, of simply starting the Remaster :

Looking a bit closely this LIST + mark is really a non-standard way to lookup for loops, coming from Apple and completly deprecated, instead of using standardized smpl.

Anyway, the LIST chunk is a special case of a container that can contain litterally any sub-chunk, so if indeed LIST + mark must be checked >= 32 bytes, on the other end a smaller chunk is not an error so the Con_Warning ("%s contains bad LIST chunk\n", name); should be removed.

Thoughts ?

[thomashope]

If it's considered valid to not have "mark" then the warning can be removed. I just assumed it was expected based on the existing code.

I'm happy to submit a PR to remove it, or create a new PR without it if you want to revert this one.

[vsonnier]

If it's considered valid to not have "mark" then the warning can be removed. I just assumed it was expected based on the existing code.

To be clear : for our case, if we have LIST AND 32 Bytes AND mark THEN we can process it, otherwise, in all other cases of LIST, just skip.
I'm not saying the presence of mark is optional and we should read the data anyway ! :)

So, we just need to remove

else
{
	Con_Warning("%s contains bad LIST chunk\n", name);
}

[sezero]

Was I too hasty merging? Shameful of me.

Can you guys give me a tested follow-up patch?

[sezero]

Can you guys give me a tested follow-up patch?

Is Novum/vkQuake@bd15df1 enough?

[vsonnier]

Is Novum/vkQuake@bd15df1 enough?

I think so.

[sezero]

Is Novum/vkQuake@bd15df1 enough?

I think so.

OK, applied.