Feature/onion request refactor#1792
Merged
ThomasSession merged 84 commits intodevfrom Jan 14, 2026
Merged
Conversation
SessionHero01
approved these changes
Jan 14, 2026
Collaborator
There was a problem hiding this comment.
I think it's worth to invest in writing unit test for this class, it seems like a good candidate to do so
* Remove PushRegistryV1 as it is for legacy group only * Clean up push registration retry logic * Comments * Asserting API contract
…ession-foundation/session-android into feature/onion-request-refactor
Collaborator
There was a problem hiding this comment.
In junit test, we normally use the test rules to do thing like this. Instead of forcing the test suit to extend from a concrete class, it's more flexible to use a test rule instead. Like this:
class PathManagerTest {
@get:Rule
val logRule = MockLoggingRule() // We actually have an existing rule to set up the mock logging
@Test
fun myTest() {}
}
SessionHero01
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Networking refactor: Separation of concerns, error management, path/snodepool/swarm management, recovery strategies.