Apply Powershell Import comments#18
Open
Meatballs1 wants to merge 5367 commits into
Open
Conversation
Author
There was a problem hiding this comment.
Note to self I probably dont need Execution Policy bypass on commands!
The Gemfile was badly formatted anyway, since it lacked a justifying comment, as all other included gems have.
This looks good to me, the whole print statement is enclosed in a check for results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have removed the traces of ". " is not required on the command line after -c or -Command.
I have removed the usage of " around the executable. The main reasons for this is if " is filtered or ' is filtered it should be easier to gsub them in an exploit.
I have moved the byte buffer text creation to the Rex module and directed Rex::Text to this.
I have added -nop -ep bypass and -w hidden to all the commands
I have reverted Util::Exe to upstream