Backport release/v6.3: feat: add configurable I/O rate limiting for snapshot writes
#2825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-2816-to-release/v6.3
git worktree add --checkout .worktree/backport-2816-to-release/v6.3 backport-2816-to-release/v6.3
cd .worktree/backport-2816-to-release/v6.3
git reset --hard HEAD^
git cherry-pick -x 28bc1c02ca94b9233c0be8f5fdd2ff94eb124622
git push --force-with-lease |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/v6.3 #2825 +/- ##
================================================
+ Coverage 43.36% 43.39% +0.02%
================================================
Files 1866 1866
Lines 155344 155399 +55
================================================
+ Hits 67368 67437 +69
+ Misses 81959 81951 -8
+ Partials 6017 6011 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Add global rate limiting for snapshot write operations to prevent page cache eviction on machines with limited RAM. Changes: - Add SnapshotWriteRateMBps config field (default 100 MB/s) - Implement rateLimitedWriter with token bucket (shared across all trees) - Remove sc-snapshot-writer-limit from TOML template (hardcoded to 4, backward-compatible) - Add tests for rate limiter correctness, large writes, context cancellation, and config defaults - Update toml_test to verify new config field and absence of removed field - Switch back MADV_RANDOM after background snapshot load (cherry picked from commit 28bc1c0)
blindchaser
force-pushed
the
backport-2816-to-release/v6.3
branch
from
959e865 to
67747ed
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67747ed4bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
yzang2019
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2816 to
release/v6.3.