Skip to content

Close Events Channel - #3

Open
indiependente wants to merge 2 commits into
sebkl:masterfrom
indiependente:master
Open

Close Events Channel#3
indiependente wants to merge 2 commits into
sebkl:masterfrom
indiependente:master

Conversation

@indiependente

@indiependente indiependente commented Apr 4, 2019

Copy link
Copy Markdown

Gracefully closing channel

  • There are situations where an unclosed channel could end up in leaving the reader hanging for more data, even if a nil value has been sent.
  • Closing the channel is the right way to tell the reader that there's no more data and that it can move forward.

@indiependente
Update search.go
77032ba 
SearchStream: gracefully closing of the events channel
On line 108 there is a nil sent to the events channel which keeps the channel still open.
Changing it to a deferred close fixes the issue.
@indiependente
Merge pull request #1 from indiependente/indiependente-patch-1
dd999da 
Update search.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@indiependente