refactor: use iconStore instead of props in GeneralOptions.vue#415
Merged
sebinside merged 2 commits intosebinside:mainfrom Feb 4, 2026
Merged
Conversation
MichaHuhn
changed the title
iconStore directly instead of using propsiconStore instead of props in GeneralOptions.vue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
iconStoredirectly instead of using props.With this approach the
currentIconcan be read and updated directly.A Pinia store already unwraps each ref for you which is a bit unituitive.
That's why we can use the
storeToRefs()helper function from Pinia to convert the returnedcurrentIconinto a normal ref and simply use it like any other ref to keep it consistent.In addition, simplify some return values.