Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Oh yeah that's right. Is this only in the new |
|
Admittedly, I did not follow their complete guide, because I wanted to a.) finish this work, and b.) keep some readability in the models |
|
Yes, actually |
|
I also noticed |
|
Yes, that worked and it was only |
|
Sounds good. What is left to do in the list for v1? We can also discuss in a breakout on Thursday. |
|
Yes, let's discuss it on Thursday but I think we are basically done. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades sdssdb to version 1.0, including major dependency updates and code style improvements.
Changes:
- Upgraded SQLAlchemy from 1.x to 2.0 and psycopg2 to psycopg3
- Updated Python version requirements (3.9-4.0) and migrated build system to uv
- Standardized code style by converting all string literals from single to double quotes
Reviewed changes
Copilot reviewed 91 out of 96 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated version to 1.0.0a1, upgraded dependencies (SQLAlchemy 2.0, psycopg3), migrated to uv build system |
| python/sdssdb/connection.py | Updated SQLAlchemy API calls for 2.0 compatibility (URL.create, future flags) |
| python/sdssdb/sqlalchemy/sdss5db/init.py | Replaced declarative_base with DeclarativeBase for SQLAlchemy 2.0 |
| schema/sdss5db/vizdb/*.py | Added new sdss_id_to_astra_pipeline table and helper script |
| tests/**/*.py | Converted string quotes to double quotes throughout test files |
| .github/workflows/*.yml | Updated CI/CD workflows to use uv package manager |
| docs/sphinx/*.rst | Updated documentation for SQLAlchemy 2.0 syntax changes |
| readthedocs.yml | Updated OS version and removed deprecated configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot write a description for this pull request. |
This PR includes changes described in #267 and sub-issues to bring
sdssdbto stable development. The main changes includes:uvandruff.