Skip to content

Change MAXNUMONOFF - #166

Open
matteobachetti wants to merge 1 commit into
scottransom:masterfrom
matteobachetti:patch-1
Open

Change MAXNUMONOFF#166
matteobachetti wants to merge 1 commit into
scottransom:masterfrom
matteobachetti:patch-1

Conversation

@matteobachetti

Copy link
Copy Markdown
Contributor

Resolve #77

@scottransom

Copy link
Copy Markdown
Owner

@matteobachetti Sorry about the delay on this. I must have missed the notification when you did that.

I think it would be OK to increase MAXNUMONOFF fairly substantially, but I'm not willing to many millions, as you have it here. The reason is that in makeinf.h the INFODATA structure has a static size which includes a double precision array of:

double onoff[MAXNUMONOFF*2];

So that means each INFODATA structure would be over 6GB in size!

The proper way to do this would be to make INFODATA dynamically sized, but that greatly complicates things -- especially passing those structures to/from Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change MAXNUMONOFF

2 participants