Skip to content

refac: vampires using dict redis hget#25

Open
DasVinch wants to merge 1 commit intodevfrom
vd/batched_redis_ex
Open

refac: vampires using dict redis hget#25
DasVinch wants to merge 1 commit intodevfrom
vd/batched_redis_ex

Conversation

@DasVinch
Copy link
Copy Markdown
Member

@mileslucas

I had this file open and suddenly wondered why not have redis just return a dict because the pipeline positional structure is so annoying.
It's barely a few lines less since we have to spell out the dictionary for defaults.

There's a sibling commit in scxkw, already on origin/dev

Do you like the style?

@DasVinch
Copy link
Copy Markdown
Member Author

plus some typing hints, now camstack is aware that self.RDB is Redis | None.

Issue there is that most Redis class methods can return awaitables, so now its complaining everywhere that Awaitable types are not handled...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant