Open
Conversation
Member
Author
|
plus some typing hints, now camstack is aware that self.RDB is Redis | None. Issue there is that most Redis class methods can return awaitables, so now its complaining everywhere that Awaitable types are not handled... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mileslucas
I had this file open and suddenly wondered why not have redis just return a dict because the pipeline positional structure is so annoying.
It's barely a few lines less since we have to spell out the dictionary for defaults.
There's a sibling commit in scxkw, already on origin/dev
Do you like the style?