Conversation
Adds frozen constant modules for every consumer-facing enum in the Printavo V2 schema: ApprovalRequestStatus, ContactSortField, LineItemSize, LineItemStatus, MerchOrderDeliveryMethod, MerchOrderStatus, MerchStoreStatus, MessageDeliveryStatus, OrderPaymentStatus, OrderSortField, PaymentDisputeStatusField, PaymentRequestStatus, PoGoodsStatus, StatusType, TaskSortField, TaskableType, TransactionCategory, TransactionSource. Each module exposes named constants + a frozen ALL array. Shared RSpec example validates structure across all 18 modules. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…PI docs Replace guessed enum values with exact values from https://www.printavo.com/docs/api/v2/. Notable corrections: ContactSortField, LineItemSize (size_ prefix), LineItemStatus, MerchOrderDeliveryMethod, MerchOrderStatus, MerchStoreStatus, MessageDeliveryStatus, OrderPaymentStatus, OrderSortField, PaymentDisputeStatusField, PaymentRequestStatus, PoGoodsStatus, TaskSortField, TaskableType, TransactionCategory, TransactionSource, and ApprovalRequestStatus (added DECLINED). Update enums_spec and factories to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… constants Swap remaining literal 'approved', 'revoked', 'pending' strings in approval_requests_spec.rb for ApprovalRequestStatus::APPROVED/REVOKED/PENDING. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
Printavo::Enums— 18 frozen constant modules covering every consumer-facing enum in the Printavo V2 GraphQL schema (__DirectiveLocationand__TypeKindomitted as GraphQL introspection internals).ApprovalRequestStatusContactSortFieldLineItemSizeLineItemStatusMerchOrderDeliveryMethodMerchOrderStatusMerchStoreStatusMessageDeliveryStatusOrderPaymentStatusOrderSortFieldPaymentDisputeStatusFieldPaymentRequestStatusPoGoodsStatusStatusTypeTaskSortFieldTaskableTypeTransactionCategoryTransactionSourceEach module exposes an
ALLfrozen array. A shared RSpec example ('a Printavo enum') validates all three structural invariants across every module.Usage
Test plan
bundle exec rspec— 701 examples, 0 failures, 100% line coveragebundle exec rubocop— 217 files inspected, no offenses🤖 Generated with Claude Code