Add proper readiness checks to health interceptor#121
Merged
Conversation
- Separate liveness (/healthz) from readiness (/readyz, /healthcheck) - Liveness probe returns 200 immediately (sub-millisecond, no deps) - Readiness probes check PostgreSQL, Redis, and MongoDB connectivity - Add per-check timeout (2s) and overall timeout (5s) - Return 503 when dependencies are unhealthy or not initialized - Run all dependency checks concurrently with asyncio.gather() - Update tests to mock GlobalDependencies and verify behavior
RoxyFarhad
approved these changes
Dec 29, 2025
Contributor
RoxyFarhad
left a comment
RoxyFarhad
left a comment
There was a problem hiding this comment.
🥳 wooo thanks for catching this!!
RoxyFarhad
reviewed
Dec 29, 2025
|
|
||
| async with asyncio.timeout(DEPENDENCY_CHECK_TIMEOUT): | ||
| async with engine.connect() as conn: | ||
| await conn.execute(text("SELECT 1")) |
Contributor
There was a problem hiding this comment.
random q: no pings for PostgreSQL?
Collaborator
Author
There was a problem hiding this comment.
not sure what you mean by "pings" here? connecting to the engine feels similar (making sure the instance is reachable) and trying to run this basic query helps us confirm that the instance is actually handling requests as expected (as opposed to, say, being unresponsive)
Contributor
There was a problem hiding this comment.
sorry, I meant is there no equivalent on a DB PING (like we do for mongo or redis) for postgresql? this is obviously good too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/healthz) from readiness (/readyz,/healthcheck) probesWhy this matters
Previously, all health check paths returned 200 regardless of dependency health. This meant Kubernetes would continue routing traffic to pods that couldn't actually serve requests. Now:
/healthz(liveness): Fast response for Kubernetes to detect stuck processes/readyzand/healthcheck(readiness): Actual dependency validation before accepting trafficResponse format (readiness)
{ "status": "ok", // or "degraded" "checks": { "postgres": {"healthy": true}, "redis": {"healthy": true}, "mongodb": {"healthy": true} } }Test plan