Adapter db for trimming - #248
Closed
sainsachiko wants to merge 7 commits into
Closed
Conversation
Contributor
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
muffato
reviewed
Jul 24, 2026
muffato
left a comment
muffato
left a comment
Member
There was a problem hiding this comment.
If you want to release this as 2.0.4, you've got to base the PR on main and name your branch patch
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [[v2.0.4](https://github.com/sanger-tol/readmapping/releases/tag/2.0.3)] - Hungarian Horntail (patch 4) - [2026-release-date] |
Member
There was a problem hiding this comment.
Suggested change
| ## [[v2.0.4](https://github.com/sanger-tol/readmapping/releases/tag/2.0.3)] - Hungarian Horntail (patch 4) - [2026-release-date] | |
| ## [[v2.0.4](https://github.com/sanger-tol/readmapping/releases/tag/2.0.4)] - Hungarian Horntail (patch 4) - [2026-07-24] |
| ch_yml_barcoded = GAWK_MODIFY_YAML_BARCODE.out.output.mix( ch_yaml_meta.no_barcode ) | ||
| ch_pacbio_read_yaml = ch_reads.pacbio.combine(ch_yml_barcoded, by: 0) | ||
| adapter_fasta_for_preprocess = [[id:file( val_pacbio_adapter_fasta ).baseName], val_pacbio_adapter_fasta] | ||
| adapter_fasta_for_preprocess = val_pacbio_adapter |
Member
There was a problem hiding this comment.
Why is the [[id: ... [ structure going away ?
Contributor
Author
|
Closed to create a patch PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept adapter db for trimming with hifitrimmer to avoid makeblastdb
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).