fix(iOS): Allow notification chain forwarding for non-SFMC push notification - #5
Open
AviadKa wants to merge 1 commit into
Open
fix(iOS): Allow notification chain forwarding for non-SFMC push notification#5AviadKa wants to merge 1 commit into
AviadKa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix iOS notification chain forwarding for non-SFMC push notifications
Issue
The current implementation of
didReceiveRemoteNotification:fetchCompletionHandler:intercepts all push notifications and completes them immediately with UIBackgroundFetchResultNoData. This blocks the notification chain and prevents other plugins from receiving and processing push notifications unrelated to SFMC.Fix
Modified the implementation to handle notifications containing SFMC-specific identifiers (_sid, _m) and return NO for non-SFMC notifications, allowing them to propagate through the notification chain to other handlers.
Impact
SFMC push notifications continue to be handled correctly by the plugin
Other plugins can now properly receive and process their remote push notifications
Fixes compatibility issues with other notification-dependent plugins
Aligns with iOS best practices for plugin notification handling