iOS: complete the FlutterResult in inbox listener registration, fix double reply in setAttribute - #10
Open
fa0311 wants to merge 1 commit into
Conversation
…n and setAttribute The registerInboxResponseListener and unregisterInboxResponseListener branches of handleMethodCall never invoked the FlutterResult block, so the Dart Future returned by these method-channel calls never completed on iOS and any await on them hung forever. They now reply with result(nil) after registering or unregistering the listeners, matching the pattern used by every other branch. The setAttribute branch invoked the FlutterResult twice: once synchronously in handleMethodCall and again inside the requestPushSdk completion block of setAttributeWithKey:value:result:. Replying more than once on the same result violates the method-channel contract. The redundant synchronous reply is removed so the call replies exactly once, from the success path after the attribute is set.
nakasyou
approved these changes
Jul 19, 2026
nakasyou
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small method-channel contract issues in
SfmcPlugin.m:registerInboxResponseListener/unregisterInboxResponseListenernever invoke the result block, so on iOSawait SFMCSdk.registerInboxResponseListener(...)simply never resolves. Easy to hit if you await it during app init - there's no error, the code after the await just never runs. Android replies withresult.success(null).setAttributehas the opposite problem: it replies inside therequestPushSdkcompletion and then again synchronously right after.Three-line fix, following the pattern of the other handler branches.