Use backtrace only on systems with glibc#107
Open
psh0r wants to merge 2 commits into
Open
Conversation
Backtrace code is guarded by #ifdef, no need to abort cmake
The backtrace function is a feature of glibc. Guarding with __linux__ does not work on Linux systems, that use a different libc (e.g. musl).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #98: Remove fatal errors from backtrace check
Backtrace code is guarded by
#ifdef, no need to abortcmake.Guard backtrace code with
__GLIBC__instead of__linux__The
backtracefunction is a feature ofglibc.Guarding with
__linux__does not work on Linux systems, that use a different libc (e.g.musl).