feat: add wasm-bindgen feature for wasm#231
feat: add wasm-bindgen feature for wasm#231Its-Just-Nans wants to merge 1 commit intorusticata:masterfrom
Conversation
|
note that the I can add that on this MR Edit: DONE |
cpu
left a comment
There was a problem hiding this comment.
Seems reasonable, but is there a way to add CI coverage so that support doesn't accidentally regress?
yes, I will add that |
|
Unfortunalty it's seems not possible because of the current MSRV Or i can add dymanicly in the CI the |
cpu
left a comment
There was a problem hiding this comment.
Thanks for iterating on this, I think it's getting close :-)
I don't know how others feel, but I'd personally have an easier time reviewing this if you were able to rebase to squash your own iteration down into the original commits.
|
Thanks for the review!
Okay, I understand that the commits history is missleading since I did multiple changes. btw a save of the commit order is available on https://github.com/Its-Just-Nans/x509-parser/tree/time-wasm-bindgen-save |
592723a to
a090563
Compare
a090563 to
967826c
Compare
|
In my latest change
|
cpu
left a comment
There was a problem hiding this comment.
Thanks!
I think you misunderstood me and squashed everything into one commit. That's better and I'm OK approving, but in the future my personal preference would be something like:
- a commit fixing the typos
- a commit gating the tests that won't run on wasm32
- a commit fixing the
timedependency feature - a commit adding the test & CI integration
Hope that makes sense! I know it's more work, but in my experience it optimizes for the reviewer and it's hard to find time for this crate already :-)
|
Okay I understand, sorry for that Should I bump the https://github.com/rusticata/x509-parser/actions/runs/22038536527/job/63675425805?pr=231 |
NP!
No, it's OK to ignore that for now. There's a fix pending in #223 |
This MR add the wasm-bindgen feature of the
timecrate on wasm https://docs.rs/crate/time/latest/featuresWithout the feature we have the error
Test file
cargo install wasm-pack cargo add --dev wasm-bindgen-test wasm-pack test --node