fix: invalidate key_pair cache instead of setting directly #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using None instead of Some(key_pair) when updating the cache. If the incoming key_pair is empty, Some would cache the empty value and get_key_pair() would always return it without regenerating. Signed-off-by: 21pages <sunboeasy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #484
Using
Noneinstead ofSome(key_pair)when updating the cache. If the incoming key_pair is empty,Some(key_pair)would cache the empty value andget_key_pair()would always return it without regenerating or loading.Marked as draft because it needs to be retested.