-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Update provider API docs #150074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update provider API docs #150074
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
library/core/src/error.rs
Outdated
| /// } | ||
| /// ``` | ||
| /// | ||
| /// # Implementation Conventions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put this at the bottom of the existing doc comment but I wasn't sure if I should feature this more prominently, the only issue is I felt like it might be confusing to provide an example of what not to do before an example of how to use it properly, but the pre-existing example is quite long so I also worry that readers will entirely miss the new section.
c2fcd93 to
39760d5
Compare
This comment has been minimized.
This comment has been minimized.
39760d5 to
b30716c
Compare
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
b30716c to
dd8a64a
Compare
This comment has been minimized.
This comment has been minimized.
dd8a64a to
e6f8696
Compare
This comment has been minimized.
This comment has been minimized.
e6f8696 to
cab124b
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
cab124b to
61fd451
Compare
This comment has been minimized.
This comment has been minimized.
61fd451 to
beee074
Compare
beee074 to
b007397
Compare
Adds guidance on a specific provider API implementation anti pattern that implementers of the error trait should avoid.
resolves #99301 (comment)