svelte: Port LoadingSpinner component from Ember.js app
#12561
Merged
+77
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
svelte-loading-spinner
branch
from
4fb3f01 to
33dc782
Compare
eth3lbert
approved these changes
Dec 21, 2025
| {#if showSpinner} | ||
| <!-- TODO: <LoadingSpinner class="loading-spinner" data-test-spinner /> --> | ||
| <span class="loading-spinner" data-test-spinner>Loading...</span> | ||
| <LoadingSpinner style="margin-left: var(--space-2xs)" data-test-spinner /> |
Contributor
There was a problem hiding this comment.
It's a pity that Svelte doesn't have many options for overriding a child component's styles. I hope a better solution comes along someday! 🥲
Member
Author
There was a problem hiding this comment.
yeah, that part is certainly annoying... :-/
eth3lbert
reviewed
Dec 21, 2025
Turbo87
force-pushed
the
svelte-loading-spinner
branch
from
33dc782 to
d4e3cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related