Skip to content

Sort migrations when embedding them using embed_migrations macro#439

Open
silverpill wants to merge 1 commit into
rust-db:mainfrom
silverpill:refinery-0-8-repro
Open

Sort migrations when embedding them using embed_migrations macro#439
silverpill wants to merge 1 commit into
rust-db:mainfrom
silverpill:refinery-0-8-repro

Conversation

@silverpill

Copy link
Copy Markdown

By default, WalkDir::into_iter returns entries in the unspecified order:

The order is unspecified but if sort_by is given, directory entries are sorted according to this function.

This code is executed at compile time, so the result is not deterministic and that leads to non-reproducible builds (https://reproducible-builds.org/).

This patch enables sorting of directory entries, which makes the result deterministic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant