Cache bitcoind for CI#449
Merged
tcharding merged 4 commits intorust-bitcoin:masterfrom Jan 9, 2026
Merged
Conversation
Having `,download` in the feature list causes an issue when trying to cache the downloads because of the comma. Move the `,download` feature to the `cargo test` command instead of the matrix feature list.
jamillambert
force-pushed
the
0108-cache-bitcoind
branch
2 times, most recently
from
3dbdf8f to
26cf558
Compare
jamillambert
force-pushed
the
0108-cache-bitcoind
branch
from
26cf558 to
a9feada
Compare
Apply the changes suggested by clippy to remove the lint errors.
Cache the bitcoind binary between CI runs, keyed on OS, arch and version.
jamillambert
force-pushed
the
0108-cache-bitcoind
branch
from
a9feada to
3cc51e2
Compare
tcharding
approved these changes
Jan 9, 2026
Member
|
Legend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache bitcoind so that it is not downloaded every CI run.
,downloadto the run command since the,causes an issue when used in the cache key.BITCOIND_SKIP_DOWNLOADto 1 fordocs,docsrsandlintso that bitcoind is not downloaded when it is not needed. Since these jobs are run with a feature matrix that includeddownload.