More BinOp::Offset tests#935
Merged
automergerpr-permission-manager[bot] merged 4 commits intomasterfrom Feb 4, 2026
Merged
Conversation
dkcumming
requested review from
jberthold,
mariaKt,
palinatolmach and
tothtamas28
tothtamas28
approved these changes
Feb 4, 2026
Comment on lines
64
to
66
| 'ref-ptr-cast-arr-offset-fail', # Should pass | ||
| 'ref-ptr-cast-elem-fail', # Should pass | ||
| 'ref-ptr-cast-elem-offset-fail', # Should pass |
Contributor
There was a problem hiding this comment.
I think it's safe to remove these comments, as all the tests on this list are expected to pass and are enabled on CI.
Contributor
There was a problem hiding this comment.
Also, maybe you can add
# ref-ptr-cast-arr.rs - fails for now
or something similar to indicate that there's a test file which is not yet exercised.
Collaborator
Author
There was a problem hiding this comment.
I'll just remove them
automergerpr-permission-manager
bot
deleted the
dc/more-binop-offset-tests
branch
automergerpr-permission-manager bot
pushed a commit
to runtimeverification/solana-token
that referenced
this pull request
Feb 11, 2026
- [More BinOp::Offset tests More BinOp::Offset tests](runtimeverification/mir-semantics#935) - [fix: type of offset for applyBinOp(binOpOffset, ...) fix: type of offset for applyBinOp(binOpOffset, ...)](936) - [Add type-correcting projections on pointer cast and related operations](runtimeverification/mir-semantics#937)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more tests for correcting the semantics of
BinOp::Offset