Skip to content

Update quest-voiceover to v1.10.1#10044

Merged
riktenx merged 1 commit intorunelite:masterfrom
KevinEdry:update-quest-voiceover
Jan 12, 2026
Merged

Update quest-voiceover to v1.10.1#10044
riktenx merged 1 commit intorunelite:masterfrom
KevinEdry:update-quest-voiceover

Conversation

@KevinEdry
Copy link
Copy Markdown
Contributor

@KevinEdry KevinEdry commented Jan 2, 2026

Update quest-voiceover plugin to version 1.10.0.

Release: https://github.com/KevinEdry/runelite-quest-voiceover/releases/tag/v1.10.0
https://github.com/KevinEdry/runelite-quest-voiceover/releases/tag/v1.10.1

Features

  • Add audio queuing and fix ducking bug (375afd5)
  • Add voiceover overlay with player controls (99ea202)
  • Change default speech highlight color to blue (3928b4e)

Other Changes

  • Migrate database schema from FTS4 to regular table with indexes (2941542)

I moved the controls above the chat, and added new play/pause, and skip controls including the audio queuing feature that is now enabled by default.
image

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jan 2, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Jan 2, 2026

Feedback:

  • Use of javax.sound.sampled.AudioSystem.getLine is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.getControl is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.flush is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.close is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.open is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.getMicrosecondPosition is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.AudioFormat.<init> is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of java.lang.System.out is not allowed: system i/o, use a logger instead.
  • Use of javax.sound.sampled.SourceDataLine.start is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.stop is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.FloatControl$Type.MASTER_GAIN is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.SourceDataLine.write is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl$Type.MUTE is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.BooleanControl.setValue is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.DataLine$Info.<init> is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of java.lang.System.err is not allowed: system i/o, use a logger instead.
  • Use of javax.sound.sampled.SourceDataLine.drain is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

@KevinEdry KevinEdry changed the title quest-voiceover 1.10.0 Update quest-voiceover to v1.10.0 Jan 6, 2026
@KevinEdry
Copy link
Copy Markdown
Contributor Author

Hey, Just wanted to check in if everything is okay with the PR, is there something I should change or update?

@Felanbird
Copy link
Copy Markdown
Contributor

I would guess there isn't a rush to review this due to the 90,000 changes

@KevinEdry
Copy link
Copy Markdown
Contributor Author

I would guess there isn't a rush to review this due to the 90,000 changes

Most of the line changes are transcript json files for the quests I've added in the git repository. I realized the change is messy because of it, so that why I've added links to specific commits in the PR description that reflect the actual changes to the plugin itself.

I can remove the the transcripts from the repository if thats the feedback, but shouldn't it live in the same repo as the plugin?

@Hannah-GBS
Copy link
Copy Markdown
Contributor

I can remove the the transcripts from the repository if thats the feedback, but shouldn't it live in the same repo as the plugin?

Can they not live on a different branch?

@KevinEdry KevinEdry force-pushed the update-quest-voiceover branch from 9358e82 to d9617d2 Compare January 12, 2026 20:35
@KevinEdry KevinEdry changed the title Update quest-voiceover to v1.10.0 Update quest-voiceover to v1.10.1 Jan 12, 2026
@KevinEdry
Copy link
Copy Markdown
Contributor Author

@Hannah-GBS Thats really good advice!I moved all of the automation files to an "automations" branch.

Thanks for all of you for working with me on this 🙏

@riktenx
Copy link
Copy Markdown
Member

riktenx commented Jan 12, 2026

thanks for doing this

@riktenx riktenx merged commit 48999be into runelite:master Jan 12, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants