ci: fix Windows CRT mismatch and mark CUDA non-blocking#66
Open
pszymkowiak wants to merge 1 commit into
Open
Conversation
esaxx-rs hardcodes .static_crt(true) which forces /MT, while ort-sys prebuilt links against /MD. The mismatch surfaces as LNK2038 during the debug link step on Windows. Force /MD via CFLAGS/CXXFLAGS so cc crate's last flag wins and the CRT matches ort-sys. Also mirror release.yml's continue-on-error on CUDA matrix entries so the persistent nvidia-dkms install failure on GH-hosted runners doesn't mask the green state of the other jobs. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
`esaxx-rs/build.rs` hardcodes `.static_crt(true)` → MSVC emits `/MT`. `ort-sys` ships a prebuilt binary linked with `/MD`. The link step then aborts with `LNK2038: mismatch detected for 'RuntimeLibrary'`. Setting `CFLAGS=/MD` and `CXXFLAGS=/MD` on Windows leverages MSVC's "last flag wins" rule so esaxx-rs recompiles with `/MD`.
Release builds currently mask the same mismatch (likely via LTO + `panic=abort` + strip), so this PR intentionally only touches `ci.yml`.
Test plan