Re-evaluate topic type name and type hash#965
Conversation
Signed-off-by: Vincenzo Petrone <vipetrone@unisa.it>
Signed-off-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Vincenzo Petrone <vipetrone@unisa.it>
fujitatomoya
left a comment
There was a problem hiding this comment.
blake2 would be our option here, out of curiosity do we have any discussion on PMC meeting including pros/cons?
|
Hi @fujitatomoya, personally I don't usually take part in PMC meetings, but a discussion on this hashing scheme is reported in the referenced issue. |
|
Neat! I think the idea was that we needed a much shorter string length so that we don't use excessive amounts of memory in resource constrained devices, as reported in the issue upstream. Changing this hash will have some impact on previously recorded bag files, so we probably want to make sure that we get it correct and not introduce a lot of churn around that. Rather than having discussion at the PMC meetings, I will just flag it in the next meeting so that people know to take a look at it. |
|
Ah, but on closer inspection, you made it opt in, so maybe that takes care of some of the immediate concern there. |
|
Hi @mjcarroll, yes I made this flag optional but Is there anything else to do to address the referenced issue? |
Description
Fixes ros2/ros2#1682.
This PR introduces a new hash scheme based on BLAKE2.
Is this user-facing behavior change?
If users want to build messages with the new scheme, they should specify the
-DROSIDL_GENERATOR_USE_RIHS02=ONflag (see below).Additional Information
This PR can be tested in two ways: