Skip to content

add warning message to ensure rosidl_adaptor is available.#886

Open
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/issues-885
Open

add warning message to ensure rosidl_adaptor is available.#886
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/issues-885

Conversation

@fujitatomoya

@fujitatomoya fujitatomoya commented Aug 23, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes #885

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@fujitatomoya fujitatomoya requested a review from Copilot August 23, 2025 07:38
@fujitatomoya fujitatomoya self-assigned this Aug 23, 2025
Copilot AI reviewed Aug 23, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a warning message to inform users when rosidl_adapter is not available but non-IDL interface files are provided, helping them understand why their build might fail and how to resolve the issue.

  • Adds a warning message in the rosidl_generate_interfaces macro when rosidl_adapter is not found
  • Provides clear guidance on how to resolve the issue by adding the required package dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread rosidl_cmake/cmake/rosidl_generate_interfaces.cmake
@fujitatomoya fujitatomoya mentioned this pull request Aug 23, 2025
Open
@fujitatomoya

fujitatomoya commented Aug 23, 2025 •
edited by ahcorde
Loading

Copy link
Copy Markdown
Contributor Author

Pulls: #886
Gist: https://gist.githubusercontent.com/fujitatomoya/fdd51a657e3e7a5b7cbee9428faec2bf/raw/afbf7df8e61ab7ae002ecd54d0162b005a8c730f/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_cmake
TEST args: --packages-above rosidl_cmake
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16784

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

GuillaumeDua
GuillaumeDua reviewed Aug 23, 2025
View reviewed changes

@GuillaumeDua GuillaumeDua left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , but perhaps there's other generators and/or a specific generator API worth mentioning here ?

@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@Mergifyio rebase

@fujitatomoya
add warning message to ensure rosidl_adaptor is available.
a15809d 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@mergify

mergify Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/issues-885 branch from 424104e to a15809d Compare June 4, 2026 22:39
@fujitatomoya fujitatomoya requested a review from ahcorde June 4, 2026 22:40
@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@ahcorde can you review this?

@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #886
Gist: https://gist.githubusercontent.com/fujitatomoya/68238c3ab23367d1581c324d8536f0a0/raw/5079a215c3bfac53f989a097fdeece46fd650deb/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_cmake
TEST args: --packages-above rosidl_cmake
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19481

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@ahcorde ahcorde Awaiting requested review from ahcorde
+1 more reviewer
@GuillaumeDua GuillaumeDua GuillaumeDua left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Confusing and misleading rosidl_write_generator_arguments error

3 participants

@fujitatomoya @GuillaumeDua