Fix cmake deprecation#420
Open
mosfet80 wants to merge 2 commits into
Open
Conversation
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
Signed-off-by: mosfet80 <10235105+mosfet80@users.noreply.github.com>
fujitatomoya
reviewed
Jun 8, 2026
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with a comment.
https://cmake.org/cmake/help/latest/release/3.31.html
for most modern C++ projects, a good starting point is CMake 3.10 or later now.
according to https://github.com/ros-infrastructure/rep/blob/master/rep-2000.rst
- Humble CMake oldest version: 3.14 (Including Tier III)
- Jazzy CMake oldest version: 3.20 (Including Tier III)
i think it is okay to upgrade version 3.20 for rolling and jazzy, 3.14 for humble as base version.
can you also upgrade the CMake version for upstream branches?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cmake version < then 3.10 is deprecated
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information